Remove bundle install step from generator #3219
Draft
+12
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
reviewed
Oct 21, 2024
template.rb
Outdated
| @@ -14,6 +14,11 @@ | |||
| gem 'sidekiq' | |||
| gem 'bootstrap_form', /(\d)(?:\.\d){0,2}/.match(bootstrap_version)[1].to_i == 5 ? '~> 5.4' : '~> 4.5' | |||
|
|
|||
| if options[:asset_pipeline] == 'propshaft' | |||
There was a problem hiding this comment.
Isn't propshaft orthagonal to the two gems below. You can use these gems with Sprockets as well.
There was a problem hiding this comment.
Yes, agreed. The current state is now closer to what I was imagining, but I'm still uncertain about the Rakefile change.
taylor-steve
force-pushed
the
remove-bundle-install-step
branch
from
d34d59f
to
4070b07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.